[surf] Bookmarks patch for 0.2

[Tadeusz Sośnierz]

Hello,
I wrote some patch for bookmark handling, attached. Everything is driven
by the right-click menu. Sadly, I had no idea how to include some labels
for the urls. Also, I'm rather beggining with C, so I'm sorry for any
eye-stabbing stupidities you may encounter, and please report
them to me.

Hope You'll like it.
Regards,
Ted

[Julien Steinhauser]

Post by Tadeusz Sośnierz
Hello,
I wrote some patch for bookmark handling, attached. Everything is driven
by the right-click menu. Sadly, I had no idea how to include some labels
for the urls.

I'm sorry, I won't provide any practical help as I'm really clueless in c.

To include some label, what about adding a step where the url is given
as an input to dmenu, then you just need to tab and space once, write
your label, and make dmenu output to the bookmark file.

[Julien Pecqueur]

Post by Tadeusz Sośnierz
Hello,
I wrote some patch for bookmark handling, attached. Everything is driven
by the right-click menu. Sadly, I had no idea how to include some labels
for the urls. Also, I'm rather beggining with C, so I'm sorry for any
eye-stabbing stupidities you may encounter, and please report
them to me.
Hope You'll like it.

I'd have the same idea few weeks ago and i wrote a very-simple bookmarks
management implementation for surf (using dmenu). However, your idea of
displaying bookmarks list in a about:bookmarks page is smartest :)

Post by Tadeusz Sośnierz
+void
+addbookmark(Client *c, const Arg *arg) {
+ char *bmark_uri;
+ FILE *f;
+ bmark_uri = geturi(c);
+ f = fopen(bmarksfile, "a+");
+ fprintf(f, "%s\n", geturi(c));
+ fclose(f);
+}

The pointer *bmark_uri is not used in the function.

Good job, i'll be apply your patch this evening!

[Tadeusz Sośnierz]

Post by Julien Pecqueur

Post by Tadeusz Sośnierz
Hello,
I wrote some patch for bookmark handling, attached. Everything is driven
by the right-click menu. Sadly, I had no idea how to include some labels
for the urls. Also, I'm rather beggining with C, so I'm sorry for any
eye-stabbing stupidities you may encounter, and please report
them to me.
Hope You'll like it.

I'd have the same idea few weeks ago and i wrote a very-simple bookmarks
management implementation for surf (using dmenu). However, your idea of
displaying bookmarks list in a about:bookmarks page is smartest :)

Post by Tadeusz Sośnierz
+void
+addbookmark(Client *c, const Arg *arg) {
+ char *bmark_uri;
+ FILE *f;
+ bmark_uri = geturi(c);
+ f = fopen(bmarksfile, "a+");
+ fprintf(f, "%s\n", geturi(c));
+ fclose(f);
+}

The pointer *bmark_uri is not used in the function.

Right, my bad. Thanks for noticing!

Post by Julien Pecqueur
Good job, i'll be apply your patch this evening!

I'm glad you like it.

Regards

[Moritz Wilhelmy]

Would you please add it to the surf page in the suckless wiki?

Post by Tadeusz Sośnierz

Post by Julien Pecqueur

Post by Tadeusz Sośnierz
Hello,
I wrote some patch for bookmark handling, attached. Everything is driven
by the right-click menu. Sadly, I had no idea how to include some labels
for the urls. Also, I'm rather beggining with C, so I'm sorry for any
eye-stabbing stupidities you may encounter, and please report
them to me.
Hope You'll like it.

I'd have the same idea few weeks ago and i wrote a very-simple bookmarks
management implementation for surf (using dmenu). However, your idea of
displaying bookmarks list in a about:bookmarks page is smartest :)

Post by Tadeusz Sośnierz
+void
+addbookmark(Client *c, const Arg *arg) {
+ char *bmark_uri;
+ FILE *f;
+ bmark_uri = geturi(c);
+ f = fopen(bmarksfile, "a+");
+ fprintf(f, "%s\n", geturi(c));
+ fclose(f);
+}

The pointer *bmark_uri is not used in the function.

Right, my bad. Thanks for noticing!

Post by Julien Pecqueur
Good job, i'll be apply your patch this evening!

I'm glad you like it.
Regards
--
===========================================================
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments

[Tadeusz Sośnierz]

Post by Moritz Wilhelmy
Would you please add it to the surf page in the suckless wiki?

Sure. I'll make a fresh diff today, if there are no protests I'll be
glad to submit.

Regards,
Ted

Post by Moritz Wilhelmy

Post by Tadeusz Sośnierz

Post by Julien Pecqueur

Post by Tadeusz Sośnierz
Hello,
I wrote some patch for bookmark handling, attached. Everything is driven
by the right-click menu. Sadly, I had no idea how to include some labels
for the urls. Also, I'm rather beggining with C, so I'm sorry for any
eye-stabbing stupidities you may encounter, and please report
them to me.
Hope You'll like it.

I'd have the same idea few weeks ago and i wrote a very-simple bookmarks
management implementation for surf (using dmenu). However, your idea of
displaying bookmarks list in a about:bookmarks page is smartest :)

Post by Tadeusz Sośnierz
+void
+addbookmark(Client *c, const Arg *arg) {
+ char *bmark_uri;
+ FILE *f;
+ bmark_uri = geturi(c);
+ f = fopen(bmarksfile, "a+");
+ fprintf(f, "%s\n", geturi(c));
+ fclose(f);
+}

The pointer *bmark_uri is not used in the function.

Right, my bad. Thanks for noticing!

Post by Julien Pecqueur
Good job, i'll be apply your patch this evening!

I'm glad you like it.
Regards
--
===========================================================
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments

[Nico Golde]

Hi,
* Tadeusz So??nierz <***@gmail.com> [2009-10-20 16:36]:
[...]

+showbmarks(Client *c, const Arg *arg) {
+ /* I wonder if 4 kB is too much or not enough */
+ char html[4096] = "";
+ /* same here. time will tell */
+ char uri[128];
+ FILE *f;
+ stop(c, NULL);
+ f = fopen(bmarksfile, "r");
+ while(fscanf(f, "%127s\n", uri) != EOF) {
+ snprintf(&html[strlen(html)], sizeof(html) - strlen(html),
+ "<a href='%s'>%s</a><br />", uri, uri);

You may want to html escape the uri, not?

Cheers
Nico

[Tadeusz Sośnierz]

Post by Nico Golde
Hi,
[...]

+showbmarks(Client *c, const Arg *arg) {
+ /* I wonder if 4 kB is too much or not enough */
+ char html[4096] = "";
+ /* same here. time will tell */
+ char uri[128];
+ FILE *f;
+ stop(c, NULL);
+ f = fopen(bmarksfile, "r");
+ while(fscanf(f, "%127s\n", uri) != EOF) {
+ snprintf(&html[strlen(html)], sizeof(html) - strlen(html),
+ "<a href='%s'>%s</a><br />", uri, uri);

You may want to html escape the uri, not?

Well, there are some security reasons, if that's what you mean. But
my tiny investigation (I mean, entering query string to google
containing html tags) showed that they become urlencoded by the app
itself, so it seems safe to me. If there's anything I don't know, please
let me know.

Regards,
Ted

[Nico Golde]

Hi,

Post by Tadeusz Sośnierz

Post by Nico Golde
[...]

+showbmarks(Client *c, const Arg *arg) {
+ /* I wonder if 4 kB is too much or not enough */
+ char html[4096] = "";
+ /* same here. time will tell */
+ char uri[128];
+ FILE *f;
+ stop(c, NULL);
+ f = fopen(bmarksfile, "r");
+ while(fscanf(f, "%127s\n", uri) != EOF) {
+ snprintf(&html[strlen(html)], sizeof(html) - strlen(html),
+ "<a href='%s'>%s</a><br />", uri, uri);

You may want to html escape the uri, not?

Well, there are some security reasons, if that's what you mean. But
my tiny investigation (I mean, entering query string to google
containing html tags) showed that they become urlencoded by the app
itself, so it seems safe to me. If there's anything I don't know, please
let me know.

OK fine. Yes that was what I meant.

Cheers
Nico